The Joy of Coding: Episode Guide

Volunteer-driven episode guide for The Joy of Coding

---

Project maintained by mikeconley Hosted on GitHub Pages — Theme by mattgraham

Episode 318: Mar 8th, 2023

Links

• Watch this episode on Air Mozilla
• Joplin Agenda

Topics

• Bug 1529276 - resource:///modules/WindowsJumpLists.jsm still does main thread I/O

• Still hacking on WindowsJumpLists!

  • Goal: I want the JumpListManager to only ever be accessed off of the main thread, so that the main thread in the parent process never has to await a lock.
    • Get rid of maxListItems, since it doesn’t appear to be used
    • Get rid of isListCommitted
    • Make .available return a Promise
    • Make abortListBuild return a Promise
    • Make deleteActiveList return a Promise
    • Make SetAppUserModelId return a Promise
    • Add WebIDL for JumpListShortcutDescription and add populateJumpList method to JumpListBuilder.
    • Custom List (this is the Frequently Visited stuff) - Frequent is ENABLED by default - Recent is DISABLED by default - Don’t need separators
    • Tasks
    • Update methods so that tasks and custom lists are added in the same method call. So a single populate method that takes something like… (taskDescriptions, customTitle, customListDescriptions)
    • Finish the URL removal thing. Basically, if an item was removed via the shell, the next call to AppendCategory cannot include that item with the same display name - the next call needs to display something else entirely.
    • Implement clearJumpList (it’s called deleteActiveList)
    • Handle the URL removal case
    • Handle re-entry to buildList
    • What was with that NS_ERROR_FAILURE we saw after caling .update() not long after startup?
    • See how Thunderbird uses JumpListBuilder in case there are things we need to support there.
      • It’s a simple usage. They don’t have any custom items. We should support the no-custom-items case.
    • How about private browsing windows? How do the icon caches work for those? How do the built lists work for those?
    • Make our approach preffable. Put all the old stuff back (gulp), and update WindowsJumpList to use the new mechanism on a pref.
    • Figure out how to make the above testable. Then write tests.
      • Let’s update WinTaskbar to have a new method that can be accessed from native code (so not through XPCOM), called, like, DoCreateJumpListBuilder or something. Have it take an argument that is a reference to something that implements a JumpListManager interface. Have JumpListBuilder move that thing to the background thread - the background thread owns it. Then, in our tests, have our GTest call DoCreateJumpListBuilder, passing it something that mocks out JumpListManager. And then call it’s populateJumpList method for testing.

(abstract) class JumpListManager HRESULT BeginList HRESULT AddUserTasks HRESULT AppendCategory HRESULT CommitList

// Two implementations: // 1: "Real" one that wraps one of these things: RefPtr jumpListMgr; HRESULT hr = ::CoCreateInstance( CLSIDDestinationList, nullptr, CLSCTXINPROCSERVER, IIDICustomDestinationList, getter_AddRefs(jumpListMgr));

// 2: "Fake" one that allows us to interrogate it for things it has been passed, for testing. class MockJumpListManager HRESULT BeginList(outparam maxitems and outparam IObjectArray) Wants to be prepared to provide an outparam which is an IObjectArray. We can do that by creating an empty collection, or a collection that returns ShellLinks. HRESULT AddUserTasks(collection) Takes an array of tasks and returns an HRESULT. We can then examine what was passed. HRESULT AppendCategory(string, collection) Takes a string and collection for the custom list. HRESULT CommitList Just returns an HRESULT. 

We’re going to be calling PopulateJumpList method on the JumpListBuilder, and then what we can do is take the returned DOM Promise and use a DOMPromiseListener to set up some lambda functions that write into some Maybe’s like this, and then we spin the event loop (like that prior example) to wait until the Promise either resolves or rejects and then we assert the resolving or the rejecting.

• Rate this episode

Chat

• Join us on Matrix!

Other

• Felicia Bacon
• npb hacks on the SpiderMonkey JS engine
• Compiler Compiler live stream
• Try out Mozilla VPN
• How mconley uses Mercurial
• Fission - Read more about it
• mozconfigwrapper - A Wrapper to keep different mozconfigs
• MyQOnly Mikes Addon for showing how many reviews are in your review queue - Source at Github
• Mike’s Firefox Color Theme
• Check if a service you are using, has been part of a breach via Firefox Monitor
• Codetribute - Help contribute to Firefox, good mentored bugs for You.
  • First, Create a Mozilla Bugzilla account.